search

tmanderson / ivona-node

Ivona Cloud (via Amazon services) client library for Node
32 stars 5 forks source link

This code needs tests around its functionality #3

Open stsvilik opened 8 years ago

stsvilik commented 8 years ago

If you intend to make it popular and growing you will need to put together tests around its functionality. You could start with mocha + istanbul for code coverage.

tmanderson commented 8 years ago

I definitely agree with you there. I'll have to dig into the proxy module a bit more (and potentially update this), as it was a contributed from @kuzzmi.

kuzzmi commented 8 years ago

@tmanderson, I'm still here, so if any help is needed, just let me know. Probably the proxy module will require some more testable structure, so I'll take a look at it once again.

tmanderson commented 8 years ago

@kuzzmi that would be awesome if you could get started on that! I can follow suit on the main module for the bits that are there.

Thanks!

stsvilik commented 8 years ago

The proxy error I was getting is “SSL23_GET_SERVER_HELLO:unknown protocol” which was mainly caused by proxy not being able to communicate over https.