search

tmeasday / meteor-router

MIT License
366 stars 76 forks source link

Add a support for Shark. #136

Closed Slava closed 10 years ago

Slava commented 10 years ago

It can be useful for easy porting old projects to a new rendering engine (Spark->Shark) or just for people who don't know how to use IR yet (like me).

Slava commented 10 years ago

Wow, Travis CI failed on everything. Before submitting the PR I ran tests on both 0.6.6.3 and 'template-engine-preview-5' - tests passed. Maybe the difference is in meteorite? I ran tests with meteor --release option.

tmeasday commented 10 years ago

Hey @Slava - not on a good connection right now so I can't look at this - but can I ask, is there a particular feature of router that you need that's not simple to do with IR? (or have you just not looked at IR yet?). Or is it just some "legacy" code? :)

Slava commented 10 years ago

I have a new app I need to finish today and it didn't have any kind of routing. meteor-router is simple enough and I remember how to use it, IR would require good hours reading Discover Meteor or 34Kb ReadMe. It's not IR, it is me.

tmeasday commented 10 years ago

Hehe. Yes, Chris errs on the side of more information. Possibly the introduction might be enough to get you doing what you need?

Really it should be easy to do anything with IR that you can do with Router. Perhaps I should write a simple "Router -> IR transition" document for people to read.

On Thu, Dec 5, 2013 at 9:24 PM, Slava Kim (Vyacheslav) < notifications@github.com> wrote:

I have a new app I need to finish today and it didn't have any kind of routing. meteor-router is simple enough and I remember how to use it, IR would require good hours reading Discover Meteor or 34Kb ReadMe. It's not IR, it is me.

— Reply to this email directly or view it on GitHubhttps://github.com/tmeasday/meteor-router/pull/136#issuecomment-29886625 .