Keep the cursor in the same place when reformatting

russell commented 5 years ago

When reformatting buffers, the cursor always ends up at the end of the buffer.

Description

Save the position of the window and the point, then restore both after replacing the buffer contents.

Motivation and Context

it's very annoying if you use this function in large files, because it always move the cursor to the end of the file.

How Has This Been Tested?

I use it daily, and i have shared it with other members of my team.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project (see https://github.com/bbatsov/emacs-lisp-style-guide).
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

seh commented 5 years ago

Note that #12 achieves the same result. For some reason, we haven't seen any feedback from the maintainers for that one.

russell commented 5 years ago

Sweet as, I'm going to switch to your branch locally and try it. Your change looks like it also addresses the problem where the buffer is entirely replaced by an error message. I'll try it and get back to you next week

russell commented 5 years ago

closed in favour of #12

tminor / jsonnet-mode