search

toast-tk / toast-tk-engine

The core automation framework for your acceptance tests
http://toast-tk.io
Other
12 stars 5 forks source link

63 local runner #163

Closed NathCoco closed 6 years ago

skokaina commented 7 years ago

SonarQube analysis reported 48 issues

Watch the comments in this conversation to review them.

6 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR AdaptersConfig.java#L32: Constructor has 8 parameters, which is greater than 7 authorized. rule
  2. MAJOR new_project_report_template.html#L3: Add a 'favicon' declaration in this 'header' tag. rule
  3. MAJOR new_project_report_template.html#L3: Add a tag to this page. <a href="https://sonarcloud.io/coding_rules#rule_key=Web%3APageWithoutTitleCheck"><img src="https://sonarsource.github.io/sonar-github/rule.png" alt="rule" /></a></li> <li><img src="https://sonarsource.github.io/sonar-github/severity-minor.png" alt="MINOR" title="Severity: MINOR" /> <a href="https://github.com/toast-tk/toast-tk-engine/blob/32c20d07e7ccb80ed932c8fe710aeed6b0897983/toast-tk-runtime-api/src/main/java/io/toast/tk/core/event/new_project_report_template.html#L152">new_project_report_template.html#L152</a>: Replace this <i> tag by <em>. <a href="https://sonarcloud.io/coding_rules#rule_key=Web%3ABoldAndItalicTagsCheck"><img src="https://sonarsource.github.io/sonar-github/rule.png" alt="rule" /></a></li> <li><img src="https://sonarsource.github.io/sonar-github/severity-minor.png" alt="MINOR" title="Severity: MINOR" /> <a href="https://github.com/toast-tk/toast-tk-engine/blob/32c20d07e7ccb80ed932c8fe710aeed6b0897983/toast-tk-runtime-api/src/main/java/io/toast/tk/core/event/new_project_report_template.html#L161">new_project_report_template.html#L161</a>: Replace this <i> tag by <em>. <a href="https://sonarcloud.io/coding_rules#rule_key=Web%3ABoldAndItalicTagsCheck"><img src="https://sonarsource.github.io/sonar-github/rule.png" alt="rule" /></a></li> <li><img src="https://sonarsource.github.io/sonar-github/severity-minor.png" alt="MINOR" title="Severity: MINOR" /> <a href="https://github.com/toast-tk/toast-tk-engine/blob/32c20d07e7ccb80ed932c8fe710aeed6b0897983/toast-tk-runtime-api/src/main/java/io/toast/tk/core/event/new_project_report_template.html#L169">new_project_report_template.html#L169</a>: Replace this <i> tag by <em>. <a href="https://sonarcloud.io/coding_rules#rule_key=Web%3ABoldAndItalicTagsCheck"><img src="https://sonarsource.github.io/sonar-github/rule.png" alt="rule" /></a></li> </ol> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>