search

tobilg / facebook-events-by-location-core

[DEPRECATED] Search Facebook events by location and proximity.
MIT License
141 stars 56 forks source link

Remove schema from EventSearch #19

Closed Renatopster closed 7 years ago

Renatopster commented 7 years ago

Schema definition is using fs module, which is not listed in project dependencies nor automatically available in every dependent environment (eg: ionic app). Since schema is being used only for the tests and it is already redefined there, maybe we could just remove it from the main class.

tobilg commented 7 years ago

fs is a core module in Node, so I‘m not sure what you’re aiming at with that PR to be honest. Also, the function you’re removing is needed by the tests.

This project is meant to be used on the server side, and not in something like ionic.

Renatopster commented 7 years ago

My goal here is to be able to use your library directly in client apps without having to keep a server up, considering it is basically a wrapper to FB API.

We could easily make it happen by keeping fs usage only in the tests (which runs in Node, so we're fine).

I checked it and the method it's not currently being used. Tests failed in CI because of missing access token, but in my local machine they were all successful. I guess the method was used in the tests a long time ago and then got refactored at some point?

tobilg commented 7 years ago

You're right, I seemingly have removed this. Thanks for the PR, merged. I'll release a new version on NPM today.

tobilg commented 7 years ago

Published to NPM as 0.6.1.