search

tobybatch / kimai2

Docker containers for the kimai2 web application including docker-compose and kubernetes/helm deployment.
MIT License
183 stars 97 forks source link

docs: add now mandatory serverVersion parameter to DATABASE_URL #532

Closed pbek closed 1 year ago

pbek commented 1 year ago

See https://github.com/tobybatch/kimai2/issues/531#issuecomment-1686333050

sharky98 commented 1 year ago

Hi, some comments when hitting this issue with the docker images.

  1. I think you missed the file at the root.

https://github.com/tobybatch/kimai2/blob/72cdcfc4ac470a0e96c73350f21aefdf43d950ca/docker-compose.yml#L45

  1. Updating the main docs.

https://github.com/tobybatch/kimai2/blob/72cdcfc4ac470a0e96c73350f21aefdf43d950ca/docs/index.md?plain=1#L28

  1. Adding a note about a "breaking" changes in the update docs.
## Upgrading to image `kimai/kimai2` version `2.0.30`

When Upgrading to an image version that is above 2.0.30 from a version below 2.0.30, you may need to change the `DATABASE_URL` environment variable in the `kimai` service to add `?charset=utf8&serverVersion=5.7` and using double quote for the string. See the examples files.
sharky98 commented 1 year ago

Another thing, in my case, using quotes around the environment variable broke the images for me 🤷.

- DATABASE_URL=mysql://kimaiuser:kimaipassword@sqldb/kimai?charset=utf8&serverVersion=5.7
pbek commented 1 year ago

Another thing, in my case, using quotes around the environment variable broke the images for me 🤷.

Strange, I had to use them because of the = in the config...