I'd completely missed the rule that public companies are allowed to issue shares to the open market, apart from on their first operating turn. This pull request adds this step.
Fixes #11221.
This will break almost all 18Ardennes game. These can all be fixed by the default migrate games script, which will add passes for all the issue shares steps.
This pull request also fixes a bug (not reported on Github) where, when exchanging a minor company for a market share, one exchange button was being generated for each of the public company's shares in the open market. Just one button is needed.
Before clicking "Create"
[x] Branch is derived from the latest master
[x] Add the pins or archive_alpha_games label if this change will break existing games
[x] Code passes linter with docker compose exec rack rubocop -a
[x] Tests pass cleanly with docker compose exec rack rake
Implementation Notes
I'd completely missed the rule that public companies are allowed to issue shares to the open market, apart from on their first operating turn. This pull request adds this step.
Fixes #11221.
This will break almost all 18Ardennes game. These can all be fixed by the default migrate games script, which will add passes for all the issue shares steps.
This pull request also fixes a bug (not reported on Github) where, when exchanging a minor company for a market share, one exchange button was being generated for each of the public company's shares in the open market. Just one button is needed.
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rake