tobymao / saq

Simple Async Queues
https://saq-py.readthedocs.io/en/latest/
MIT License
577 stars 39 forks source link

fix: Queue.listen connection leak #100

Closed barakalon closed 12 months ago

barakalon commented 12 months ago

Queue.listen has a connection leak.

This fixes it by moving to a singleton pubsub instance that routes message in-process.

tobymao commented 12 months ago

@barakalon just for curiosity, can you run the benchmarks pre and post? you can adjust the benches to leverage this new stuff

barakalon commented 12 months ago

Struggling a bit with the rq benchmarks, since the newer version logs a bunch of crap. But there's no noticeable change in saq numbers.

tobymao commented 12 months ago

Struggling a bit with the rq benchmarks, since the newer version logs a bunch of crap. But there's no noticeable change in saq numbers.

don't worry about RQ. ok let's merge it