search

tobyspark / folk-rnn-webapp

A community application for the folk-rnn folk music style modelling project
MIT License
3 stars 5 forks source link

TMFS: Navigating tunebook #94

Closed boblsturm closed 6 years ago

boblsturm commented 6 years ago

I would like all pages to be linked here, e.g., instead of just just previous and next, put 1, 2, 3, 4, 5, 6, 7. Also, repeat this at the bottom of the page.

Also and option to view all on one page.

image

tobyspark commented 6 years ago

Yep, this is reasonable. 'View all' might need some kind of limit to stop it consuming all resources and falling over.

tobyspark commented 6 years ago
screen shot 2018-09-19 at 15 30 56

Not deployed yet, but some work has been done on this. #122

tobyspark commented 6 years ago
screenshot 2018-10-25 at 14 32 33 screenshot 2018-10-25 at 14 32 39
tobyspark commented 6 years ago

Didn't like that in the end. Didn't fit visually.

screenshot 2018-10-24 at 17 28 51

That was better in terms of visual fit but still wasn't much help navigation wise (e.g. "next" not obvious and moved around). In the end, what really makes the difference is 'view all', and – I now realise – if made available to authenticated users only my abuse-the-server concerns go away.

tobyspark commented 6 years ago
screenshot 2018-10-25 at 14 37 50 screenshot 2018-10-25 at 14 37 58

Implemented in #122

boblsturm commented 6 years ago

I like the ability to select a page before, a page after, beginning or end.