Closed anajsana closed 4 months ago
Name | Link |
---|---|
Latest commit | cd147633f5d96d63e1ef9157b30a07b98e6e8169 |
Latest deploy log | https://app.netlify.com/sites/ospomindmap/deploys/660c25c7b4d5b600081f5d84 |
Name | Link |
---|---|
Latest commit | cd147633f5d96d63e1ef9157b30a07b98e6e8169 |
Latest deploy log | https://app.netlify.com/sites/ospobook/deploys/660c25c760a50f00083176bb |
Deploy Preview | https://deploy-preview-455--ospobook.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@anajsana I think that this PR and the google doc have become out of sync. At least, I believe there is more input on the google doc since this PR has been created!
This PR could be merged and the next round of changes added later, or we could abandon this PR and go back to editing - what do you prefer?
@anajsana I think that this PR and the google doc have become out of sync. At least, I believe there is more input on the google doc since this PR has been created!
This PR could be merged and the next round of changes added later, or we could abandon this PR and go back to editing - what do you prefer?
Good point, @alice-sowerby. It seems that this PR was created in the past and is now far behind the live version / main branch (see here). I noticed that the Google Doc is more aligned with the structure / content of the main branch of chapter-4.md, not the branch in this PR. +1 to close this PR without merging and open a new PR based on the g Doc.
PS: before doing this, we should make sure that the use case on the "Social Engineering Attack on Upstream xz/liblzma" that @UlisesGascon reviewed is also included in the new PR (so we don't lose this contribution)
Included the changes from this PR in a new PR that contains the review of chapter 4 here: https://github.com/todogroup/ospology/pull/500 - also including @UlisesGascon change
Based on discussions from the past contributors' call: https://docs.google.com/document/d/1lbq_EfpAS3B7ygh8LkqLXiheAFwKWx3gYORAB7Aggio/edit
Two main scenarios were discussed:
Several best practices were raised during the call (see meeting notes for reference)