search

tog22 / eahub

EA Hub
7 stars 1 forks source link

Ex. Add padding to all causes drop down on EA Donation Registry #5

Closed cdc482 closed 9 years ago

cdc482 commented 9 years ago

/donations

tog22 commented 9 years ago

What it should look like (though feel free to change):

screen shot 2015-06-15 at 17 41 08

cdc482 commented 9 years ago

Tom, this is done. Not really happy with the display though...looking into the css. I think we need to change the type or class...

peterhurford commented 9 years ago

@cdc482 @tog22 Is there a PR for this?

tog22 commented 9 years ago

The relevant CSS isn't actually in github atm - I (or Chris) still need to do https://github.com/tog22/eahub/issues/4

On 5 July 2015 at 14:53, Peter Hurford notifications@github.com wrote:

@cdc482 https://github.com/cdc482 @tog22 https://github.com/tog22 Is there a PR for this?

— Reply to this email directly or view it on GitHub https://github.com/tog22/eahub/issues/5#issuecomment-118669675.

peterhurford commented 9 years ago

I see; thanks.

cdc482 commented 9 years ago

Done! Turns out it's a browser issue, not a CSS issue. Styling select elements inside other elements seems to frustrate lots of web developers for this reason. Anyway, in case you ever run into this again, theirs a really handy attribute for select elements---style:"width:100%;max-width:90%". Obviously you could probably think of several other fixes involving changing css files (or even javascript and php apparently), but this is definitely the "cleanest" fix. Was it worth spending all day on such a minor issue? Probably not, but I learned a lot. And at least I got something done today...pending your approval Tom.

peterhurford commented 9 years ago

Awesome; thanks for the hard work @cdc482 !

tog22 commented 9 years ago

Approved in the email thread.

On 7 July 2015 at 21:46, Peter Hurford notifications@github.com wrote:

Awesome; thanks for the hard work @cdc482 https://github.com/cdc482 !

— Reply to this email directly or view it on GitHub https://github.com/tog22/eahub/issues/5#issuecomment-119430028.

peterhurford commented 9 years ago

@tog22 should we close this issue?

cdc482 commented 9 years ago

I have a little more work to do, based on the email. Ill close it tonight (hopefully).

On Wed, Jul 8, 2015 at 5:05 PM, Peter Hurford notifications@github.com wrote:

@tog22 https://github.com/tog22 should we close this issue?

— Reply to this email directly or view it on GitHub https://github.com/tog22/eahub/issues/5#issuecomment-119730920.

cdc482 commented 9 years ago

Actually, it turns out that---like the original issue--the issue of the submit button dropping to the next line upon narrowing the window has many "quick" fixes changing css file(s) (apparently javascript and php code can do the same), but I'm not convinced that they are good fixes. I'm going to create a new task for that issue, so that I can spend the time needed to thoroughly research it and (hopefully) find a simple solution.

tog22 commented 9 years ago

A quick fix would be fine given other priorities, though it's ultimately up to you :smile: