search

toji / gl-matrix

Javascript Matrix and Vector library for High Performance WebGL apps
glmatrix.net
MIT License
5.4k stars 725 forks source link

Some return types don't include `null` #456

Open Stuk opened 1 year ago

Stuk commented 1 year ago

The return type for some functions does not include null:

https://github.com/toji/gl-matrix/blob/4480752e5dc58a56aa9e14e3040b64bd46726aec/src/mat4.js#L286-L293

when in actuality they can return null:

https://github.com/toji/gl-matrix/blob/4480752e5dc58a56aa9e14e3040b64bd46726aec/src/mat4.js#L328-L330

This can lead to unexpected runtime errors.

factscub commented 1 year ago

i would like to work on this issue. please assign me.