search

tolgee / figma-plugin

MIT License
9 stars 3 forks source link

Figma plugin improvements #25

Closed stepan662 closed 7 months ago

stepan662 commented 8 months ago
stepan662 commented 7 months ago

I'll need more info about icons - tested font awesome apporach - as it uses regular text component to render icons, but it's a bit different behavior, then I saw earlier. However I'm not sure how to address this issue - we might be checking the font of the text node, but then we need to know all possible icon fonts.

stepan662 commented 7 months ago

Leaving the last point for further research.

patrick-alpcot commented 7 months ago

Hi @stepan662 , I think that one could be tricky...

You could always leave heavy lifting to the designer...

Here are some ideas:

  1. You could add an ignore button.

    • This would hide ignore the text layer in the plugin
    • This would only be useful if the text layer would still be ignored when you launch the Tolgee plugin the next time too.

  2. You could ignore text layers that are prefixed or suffixed with an underscore or something like "icon_"

    • with this option, the designer needs to rename the icon layers so that they are ignored from the plugin.
stepan662 commented 7 months ago

Yeah, thats what I was also thinking about - have some ignore button, the prefix thing, I'm not sure about - I was testing font awesome and it doesn't have any clear prefix to identify. We'll make some more rounds of user feedback, so we'll elaborate on that.

BTW, what icon library are you using @patrick-alpcot ?

patrick-alpcot commented 7 months ago

We're using Fontawesome.

Regarding the second option, it wouldn't have anything to do with fontawesome specifically. I was actually thinking that the user (designer) would change the layer names in Figma themselves. It would be more of a general way to exclude text layers from the tolgee plugin. So, it would not be specifically tied to icon fonts only, but maybe also for numbers, dates, etc.

Here's a screen recording to explain the idea: https://alpcotpartners-my.sharepoint.com/:v:/r/personal/patrick_nel_alpcot_se/Documents/Shared%20Externally/Tolgee/Tolgee%20ignore%20text%20layers-1080p.mov?csf=1&web=1&e=O4RFp3

stepan662 commented 7 months ago

We'll discuss it also with our designer.