search

tom-dalton-fanduel / fdjangodog

A simple Django middleware for submitting timings and exceptions to Datadog.
Other
11 stars 3 forks source link

Add Trove classifiers for PyPi #13

Closed PCManticore closed 6 years ago

PCManticore commented 6 years ago

These would help understanding from a glance what Python versions are supported by fdjangodog and it they are also used by tools such as caniusepython3, which relies on trove classifiers to figure out if a library supports Python 3 or not.

I added classifiers for versions supported in tox.ini.

tom-dalton-fanduel commented 6 years ago

Seems fine to me, I wasn't previously aware of Trove. i'm assuming tools like caniusepython3 would need this to be in a released package, rather than just in the source here on github. E.g. I'll need to create a new release once this is merged for it to be useful?

PCManticore commented 6 years ago

Yup, this would need a release to be there. But if I'm not mistaken, a simple setup.py register should re-update the classifiers without needing a new release per se.

tom-dalton-fanduel commented 6 years ago

It's all good, I realised it would be easier to do a new release rather than wait for your (surprisingly rapid) response :-)

Released as 0.5.1

tom-dalton-fanduel commented 6 years ago

(Also, thanks for the contribution)