5.5.0 menu not closing after selection youtube-download.lua

tomasklaen / uosc

Feature-rich minimalist proximity-based UI for MPV player.

GNU Lesser General Public License v2.1

1.85k stars 69 forks source link

5.5.0 menu not closing after selection youtube-download.lua #978

Closed mrfragger closed 2 months ago

mrfragger commented 2 months ago

Pretty sure this is uosc related as in 5.2.0, 5.3.1, 5.4.0 it always closed after selecting download subs or video, etc.

5.5.0 it just remains open and one must hit ESC or click outside window to close it even after choosing download subs or download video.

tomasklaen commented 2 months ago

The script author is explicitly configuring menu to stay open after item is activated (keep_open = true):

https://github.com/cvzi/mpv-youtube-download/blob/d2c1eec49bec30995a446850fb10cd0b204aaf51/youtube-download.lua#L1254-L1260

I did fix keep_open not working yesterday, but I thought I broke it just a couple days ago. It's possible it was broken for a longer time and none noticed, and cvzi just added that prop thinking it does something else and left it there. Dunno.

mrfragger commented 2 months ago

thanks....it was always configured like this but never worked I guess as it always closed type = 'yt_download_menu', title = locale('Download'), keep_open = true,

changed it to type = 'yt_download_menu', title = locale('Download'), keep_open = false,