Validation test for expirationDate format

tomasmcguinness / pkpassvalidator

Checks the validity of a PKPASS file by checking it's signature and contents match the Apple specification

MIT License

77 stars 20 forks source link

Open ktwbc opened 6 years ago

ktwbc commented 6 years ago

Just a note on something that will cause a pkpass to fail but your validator passes, is the date format of expirationDate (and probably relativeDate)

The date format has to be ISO format but cannot contain milliseconds. For example a coupon can contain:

         "expirationDate":"2020-08-25T15:03:03.000Z"

will fail IRL, but pass this validation script. It should be:

         "expirationDate":"2020-08-25T15:03:03Z"

I would submit a PR but I guess this is written in Csharp? Which I don't know.

tomasmcguinness commented 6 years ago

Thanks. This was raised in https://github.com/tomasmcguinness/dotnet-passbook/issues/73 too. I'll get to it as soon as I can!