search

tomasnorre / crawler

Libraries and scripts for crawling the TYPO3 page tree. Used for re-caching, re-indexing, publishing applications etc.
GNU General Public License v3.0
54 stars 84 forks source link

[TASK] Fix CSS class for select item in backend module #1080

Closed derhansen closed 3 months ago

tomasnorre commented 3 months ago

First, thank you for your contribution, that one slipped my attention.

I don't get why all the tests are red, your change should have nothing to do with that.

Can I get you to add a comment to the CHANGELOG.md just for triggering a new build, don't know if anything timed out before I approved the workflow.

derhansen commented 3 months ago

Maybe problems with testing framework. There was just released a news version recently - see https://github.com/TYPO3/testing-framework/releases/tag/8.1.1

tomasnorre commented 3 months ago

It works locally with the 8.1.1 tag with both PHP 8.1 and 8.3, so I don't think that's the problem. I have merged your change as it cannot break anything besides layout.

tomasnorre commented 3 months ago

Strange it worked in the merge to main. https://github.com/tomasnorre/crawler/actions/runs/9623324396/job/26545650109