search

tombatossals / angular-leaflet-directive

AngularJS directive to embed an interact with maps managed by Leaflet library
http://tombatossals.github.io/angular-leaflet-directive
MIT License
1.5k stars 635 forks source link

fix karma: Fix Leaflet vector markers file name #1127

Closed mkly closed 7 years ago

mkly commented 8 years ago

Leaflet.vector-markers has changed the filename for the dist/ JavaScript files in 0.0.5

https://github.com/hiasinho/Leaflet.vector-markers/tree/0.0.4/dist https://github.com/hiasinho/Leaflet.vector-markers/tree/0.0.5/dist

This causes the plugin tests to fail as the file cannot be found

Use a regex to support 0.0.5 and remain backwards compatible with 0.0.4

mkly commented 8 years ago

Thanks for this great library. :beers:

I see that development has somewhat moved over to the angular-ui project, but since I am on this the repo I thought I would send this over. I've run into some other issues with tests as well, but this one seemed like low hanging fruit based on an upstream change.

mkly commented 8 years ago

Figure this project might be dead but going through and deleting some old forks and figured I would bump this just in case before closing.

mkly commented 7 years ago

Yup think we're dead. ☠️ Closing