search

tomichj / invitation

A Rails gem that can send 'scoped' invitations
MIT License
77 stars 28 forks source link

Add support for Rails 6 #28

Closed natecox closed 5 years ago

natecox commented 5 years ago

This fixes #27 by adding support for the Rails 6. Validated to work with 6.0.0.rc1 locally.

abdullah-lango commented 5 years ago

can someone please merge it. I need to use it in my Rails(6.0.0) app.

tomichj commented 5 years ago

Sorry guys, dealing with serious family health issues. Trying to deploy asap with limited time.

tomichj commented 5 years ago

I added basic appraisal support for rails 6.0.0rc1. Runs tests for rails 6.0.0rc1 successfully. Appraisal configuration is not complete: not all tests can be run in one appraisal execution yet. This will break travis for a bit. I might exclude older versions in travis for the moment.

I went ahead and pushed gem version .6. Let me know if there's problems, I'll be back when time allows.

natecox commented 5 years ago

oh, cool, I didn't know appraisal was a thing; I'll have to dig into it. My bad if I missed it in the contributing docs.

abdullah-lango commented 5 years ago

Thanks guys... its working now.