search

tommyme / vscode-bookmark-x

Drag-and-drop, grouping, sorting bookmarklet plugin
GNU General Public License v3.0
19 stars 3 forks source link

add a configuration to control whether display description for tree item #22

Closed Latria-Kure closed 2 months ago

Latria-Kure commented 2 months ago

When using line text as the description of tree item, item will become too long. The width of treeview is depended on the longest tree item, so I have to drag the horizontal scrollbar all the way to the right to click the inline button of item every time. I try to achieve this feature, but I faced two problems:

  1. After hiding the description, it's hard to distinguish between group and groupbookmark.
  2. It's hard to access WsfTreeItem.description. If I want to modify it, I have to change the constructor or access it after it is consctructed in the getChildren of dataprovider.

Could you give me some advice?

tommyme commented 2 months ago

I don't get you, In my case, it's width can be adjust by dragging the view container. How can "the width of treeview is depended on the longest tree item" happen?

image
Latria-Kure commented 2 months ago

Of course the width can be adjusted. But this means I have to resize the container every time if I want to click the inline button, unless I always keep the container very wide. This will takes up too much space.

tommyme commented 2 months ago

Why do it need to adjust the width every time? Once I get the suitable width, the view will always be displayed at this width. I don't understand why you need to keep the container very wide to click the inline button, could you please give me a picture of gif to explain?

Latria-Kure commented 2 months ago

This is the case. The suitable width which allowing click the button will take up 1/3 screen space. case

Hiding the description can reduce the space occupied by the view container to 1/7. image

tommyme commented 2 months ago

image it seems weird, on my device, no matter how short it is, it'll show inline button group.

tommyme commented 2 months ago

I think it's probably caused by other extensions, you can try to check it out by using a empty profile.

Latria-Kure commented 2 months ago

Thanks! This is what I want. Maybe some setting affect it, I will try.

Latria-Kure commented 2 months ago

Yes, you are right! A new empty profile work. I will find the reason. image

Latria-Kure commented 2 months ago

I figured it out! Set workbench.list.horizontalScrolling to false will solve it. Thank you very much! BookmarkX is perfect now!

tommyme commented 2 months ago

Excellent!