search

tommyme / vscode-bookmark-x

Drag-and-drop, grouping, sorting bookmarklet plugin
GNU General Public License v3.0
19 stars 3 forks source link

Added a command (and a keybind Ctrl+Shift+Q) that opens a quick selection menu that allows you to easily pick what the active group is #7

Closed DragosStefanNecula closed 3 months ago

DragosStefanNecula commented 3 months ago

What this PR does / why we need it:

Added a command (and a keybind Ctrl+Shift+Q) that opens a quick selection menu that allows you to easily pick what the active group is. We need this because a lot of users try to be keyboard only and not use mouse much.

Screenshot_1

When pressing the keybind it shows you the above menu that has all of the groups of the workspace-folder that is related to the currently active editor.

Which issue(s) this PR fixes

A lack of a keybind for a critical part of the functionality.

Special notes for your reviewer:

Let me know if I can help implement this in a different way if you don't like it! I would love to see this feature being part of your extension, it makes everything a bit easier :). Don't feel pressured to accept it if you don't want it, I can just have my fork of it. Hope you have a great day!

DragosStefanNecula commented 3 months ago

Hello! Thanks for your help! I enjoyed looking around your codebase to figure out how you do stuff. I just made another commit with the changes that you requested. Let me know if there is anything else.

tommyme commented 3 months ago

the new version of bookmark x will be published as soon as possible 😊

DragosStefanNecula commented 3 months ago

Thanks for letting me work on this ~ have a nice day :)

DragosStefanNecula commented 3 months ago

by the way your bookmark app is the best one in the marketplace, and I tried like 15!

tommyme commented 3 months ago

thank you! I'll keep making it better🧐