tompave / fun_with_flags

Feature Flags/Toggles for Elixir
https://hexdocs.pm/fun_with_flags/FunWithFlags.html
MIT License
1.08k stars 79 forks source link

no longer start an application #152

Closed dougw-bc closed 1 year ago

dougw-bc commented 1 year ago

This PR removes the application.ex and also removes the mod key from the application config, so nothing is started automatically.

the fun with flags supervisor MUST be included in the consuming application.

Can include documentation updates if this will be considered for 2.0 to ensure it does not break existing deployments

Relevant discussion: https://github.com/elixir-lang/elixir/issues/9683

tompave commented 1 year ago

Hey there, thank you for using the library and for working on this. Yes, that's possibly something for 2.0, but I'm not looking for PRs on this area at the moment. Sorry.