search

tomtkarl / WSCreator

Web Service Design and Generation tool
0 stars 0 forks source link

Code review & refactor. #25

Closed tomtkarl closed 11 years ago

tomtkarl commented 11 years ago

Some areas of code can probably be refactored.

tomtkarl commented 11 years ago

FunctionProvider match() method implementation can probably be moved into the FunctionProvider superclass? Rather than having same implementation in every subclass...

tomtkarl commented 11 years ago

FunctionProvider match() might not be a simple lookup as in example implementation, so best left implementation-specific.

tomtkarl commented 11 years ago

Seems like Endpoint and Servlet have a 1:1 relationship, can collapse them into one object?