search

tomusborne / generatepress

452 stars 89 forks source link

"Missing form label" accessibility error #573

Closed ifrountas closed 1 year ago

ifrountas commented 1 year ago

Description

The functiongenerate_do_search_fields() in the path generatepress\inc\structure\search-modal.php it makes inaccessible the label because:

  1. Label is missing the for attribute
  2. The input field doesn't have id in order to name the label.

Steps to reproduce

  1. Go to Customizing > Layout > Primary Navigation and check Enable navigation search modal
  2. Just check the site with Wave tool

Actual behavior

... I just made an override to the search field in my child theme but I think it would be better to fixed at the theme level.

Expected behavior

...

References