search

tomusborne / generatepress

452 stars 89 forks source link

Fix: Aria-label/read more to pass PageSpeed & A11y #574

Closed Jamesllllllllll closed 1 year ago

Jamesllllllllll commented 1 year ago

Fixes #564

Hey! I found this issue when I ran PageSpeed on a site I built. Big fan of GP and thought I'd make a contribution if you'd accept it. I'm just starting to dive into Wordpress development, so any tips or suggestions are more than welcome :)

I went with standard wording "Read more [...]" as in example #1 here

tomusborne commented 1 year ago

Thanks for this @Jamesllllllllll!

I've made an alternative here that adds a couple more filters and fixes it in multiple places: https://github.com/tomusborne/generatepress/pull/582

Jamesllllllllll commented 1 year ago

Thank you, @tomusborne !

I'll study your PR as part of my learning. Cheers.