Feature: Any plans for a v8 version?

tomvanenckevort / Codery.TextCount

Umbraco data type which wraps existing text data type controls and shows text counts and limits while you type.

1 stars 3 forks source link

Feature: Any plans for a v8 version? #7

Closed ZacP closed 5 years ago

ZacP commented 5 years ago

Any plans for a v8 version?

tomvanenckevort commented 5 years ago

Hi @ZacP,

Yes, I probably should make a start with that. Thanks for reminding me 😃

ZacP commented 5 years ago

That sounds great, Tom!

tomvanenckevort commented 5 years ago

Hey @ZacP,

I've now released v2.0.2 on NuGet and on Our that adds Umbraco v8.1. compatibility. Let me know how you get on with it 😃

ZacP commented 5 years ago

Hi Tom,

This is looking good. I found a bug for the TextCount using an RTE (for 8.2).

textcount.directive.js, line 77 change var isTinyMCE = $el.parent().hasClass('umb-rte'); to var isTinyMCE = $el.parent().hasClass('umb-rte-editor-con');

The v8 editor has a different class wrapper. Once I found this, it seems to work correctly with the RTE.

Thanks!

tomvanenckevort commented 5 years ago

Hi @ZacP,

Yes, I forgot to test it in 8.2 before releasing it last week.

Thanks for your suggested fix. I've used that to add a fix that supports both 8.1 and 8.2, and just released a new version (v2.0.3).