search

tonarino / panel-firmware

Firmware for the volume control hardware, targeting an STM32F4 board
MIT License
75 stars 10 forks source link

Fade all Leds always #26

Closed efyang closed 3 years ago

efyang commented 3 years ago

This PR fades all Led transitions at all times using an exponential moving average (as demonstrated by the fading in https://github.com/tonarino/panel-firmware/pull/25). It makes everything look really smooth in my opinion, while still being very responsive. Dependent on changes in https://github.com/tonarino/panel-firmware/pull/25, and could be tacked onto that PR as well.

efyang commented 3 years ago

Short demo:

https://user-images.githubusercontent.com/10342494/125131776-e54c5c80-e0c8-11eb-9dcb-7f1030244d01.mp4

efyang commented 3 years ago

Demo with fading constant of 0.997 (the new current one) - feel free to mess around with the value!

https://user-images.githubusercontent.com/10342494/125135186-327efd00-e0ce-11eb-8098-34fce46fbf1f.mp4

efyang commented 3 years ago

Hmmmm I don't think my rebase worked out because there are even more commits now, but I'd rather just squash and merge