tonesto7 / homebridge-smartthings-tonesto7

43 stars 86 forks source link

Zigbee Window Shade to work in Homebridge #53

Closed jsalexjs closed 5 years ago

jsalexjs commented 5 years ago

For some reason my Qmotion Zigbee Window shades don't show up in the home app, but when they assigned as dimmers on smartthings they work perfectly fine. Is there anyway you could add the Zigbee Window Shade as a supported device handler?

JJJ commented 5 years ago

I have 2 Bali shades that work and appear just fine. Unsure how Qmotion would be different.

Screen Shot 2019-08-05 at 9 27 36 PM Screen Shot 2019-08-05 at 9 28 24 PM
jsalexjs commented 5 years ago

Strange, This is what happens when the device handler is set to "Zigbee Window Shade"

[SmartThings] Device Skipped - Group unknown, Name left shade, ID 7d993a6b-8770-4798-8867-4fc4c77b5fa3, JSON: {"name":"left shade","basename":"Thing","deviceid":"7d993a6b-8770-4798-8867-4fc4c77b5fa3","status":"ONLINE","manufacturerName":"QMotion","modelName":"Rollershade Internal Battery","serialNumber":"4101","firmwareVersion":"1.0.0","lastTime":"2019-08-06T09:48:48+0000","capabilities":{"Configuration":1,"Switch Level":1,"Refresh":1,"Actuator":1,"Health Check":1,"Window Shade":1,"LightBulb":1,"WindowShade":1},"commands":{"configure":[],"setLevel":["NUMBER","NUMBER"],"refresh":[],"ping":[],"open":[],"close":[],"pause":[]},"attributes":{"level":68,"checkInterval":7320,"DeviceWatch-DeviceStatus":null,"healthStatus":null,"DeviceWatch-Enroll":null,"windowShade":"partially open","supportedWindowShadeCommands":null},"excludedCapabilities":["None"]}

jsalexjs commented 5 years ago

@JJJ Do your Bali Blinds run off ZigBee?

JJJ commented 5 years ago

@jsalexjs My particular blinds are Bali, which use Somfy, which uses Z-Wave.

The "Group unknown" message is at least part of your problem; see #19.

The "Group" really is the device type, or the "Category" which should appear as "Window Shade" but a glitch in this plugin has been preventing anything from being discovered under that category.

Until this application version is increased from 1.5.5/1.5.8 to 1.5.6/1.5.9 by @tonesto7, I believe you will continue to see experience this issue. (Even though my pull-requests were merged, SmartThings Groovy doesn't think there is anything new to pull from.)

JJJ commented 5 years ago

I've created issue #54 to try and get a version bump.

@jsalexjs one more thing; the SmartThings iOS app might require a bit of trial & error to select the correct properties. For example, in my setup, this app wants to find power, switches, levels, batteries, and shades. And every configuration save supplies a new JSON configuration array, so even changing nothing but hitting save requires new OAuth keys. Depending on what your shades want and what you want to see in Homebridge/SmartThings, you might need to set this up a few different ways before you're satisfied.

adavison007 commented 5 years ago

@jsalexjs My particular blinds are Bali, which use Somfy, which uses Z-Wave.

The "Group unknown" message is at least part of your problem; see #19.

The "Group" really is the device type, or the "Category" which should appear as "Window Shade" but a glitch in this plugin has been preventing anything from being discovered under that category.

Until this application version is increased from 1.5.5/1.5.8 to 1.5.6/1.5.9 by @tonesto7, I believe you will continue to see experience this issue. (Even though my pull-requests were merged, SmartThings Groovy doesn't think there is anything new to pull from.)

Is there a way to manually make it pull down the new code?

JJJ commented 5 years ago

You'll need to find the he_st_accessories.js file in your Homebridge checkout of this plugin, and remove this condition: fad43c9c4b7e91eba1656492f55ceaced17abfbf

Once you do that, you'll need to restart the Homebridge process, and may want to go through the whole process again just to be certain of all of the steps. I know I certainly had to do it a few times.

adavison007 commented 5 years ago

You'll need to find the he_st_accessories.js file in your Homebridge checkout of this plugin, and remove this condition: fad43c9

Once you do that, you'll need to restart the Homebridge process, and may want to go through the whole process again just to be certain of all of the steps. I know I certainly had to do it a few times.

Thanks, OK, can't find that file in accessories?

Screenshot 2019-08-07 at 20 11 57
JJJ commented 5 years ago

Try:

sudo find / -name he_st_accessories.js

jsalexjs commented 5 years ago

@JJJ

@adavison007

Removing that line of code as suggested worked great! My blinds now show up in HomeKit... but for some reason, open is closed and closed is open! Any ideas why that may be?

jsalexjs commented 5 years ago

And thank you btw for the great solution. Let’s hope this gets fixed in the next release 👍🏻

adavison007 commented 5 years ago

Try:

sudo find / -name he_st_accessories.js

@JJJ AWESOME! Found it, removed it and BOOM! works... been waiting a year for this fix, you are a star!

adavison007 commented 5 years ago

@JJJ

@adavison007

Removing that line of code as suggested worked great! My blinds now show up in HomeKit... but for some reason, open is closed and closed is open! Any ideas why that may be?

Sorry no, do you have it set as a blind in the smart things app?

JJJ commented 5 years ago

Removing that line of code as suggested worked great! My blinds now show up in HomeKit... but for some reason, open is closed and closed is open! Any ideas why that may be?

Mine don't look backwards necessarily, but I do think it's weird that HomeKit chooses to emphasize them when they are Open instead of when they are Closed. I also wish the Home app provided different icons for different equipment: shades and blinds are different things, after all!

tonesto7 commented 5 years ago

So are we good with this issue now?

JJJ commented 5 years ago

@tonesto7 I think yes.

If some blinds are reversed, I think that’s a manufacturer defect. For example, all of the Hunter WiFi fans that are HomeKit compatible rotate in the opposite direction than the Home app depicts. They’ve always been wrong, even after several years of firmware updates.

iOS 13.2 also answered my need for new icons for blinds, depicted below:

BA9C67BE-9761-4139-89F6-8AD3C6C67134

JJJ commented 5 years ago

@jsalexjs

but for some reason, open is closed and closed is open

The SmartThings iOS app now has a setting to reverse the direction. I have not tested it, but I assume that HomeKit would obey this (by not really knowing or caring; SmartThings would just be inverting the values itself.)

7E857351-B86E-49ED-BEE8-21A2312F9AFB

jsalexjs commented 5 years ago

This is really great! Thanks very much :)

adavison007 commented 4 years ago

You'll need to find the he_st_accessories.js file in your Homebridge checkout of this plugin, and remove this condition: fad43c9

Once you do that, you'll need to restart the Homebridge process, and may want to go through the whole process again just to be certain of all of the steps. I know I certainly had to do it a few times.

I've now updated to the new V2 smart app and the fix I used (above) no longer works with the v2 hmebridge install and I can't fine the sudo find / -name he_st_accessories.js file in homekit now... how do I make the same fix in V2? @tonesto7 @JJJ Thanks in advance

JJJ commented 4 years ago

@adavison007 I don't think the fix should be necessary any longer. It was eventually merged into this project.

adavison007 commented 4 years ago

@adavison007 I don't think the fix should be necessary any longer. It was eventually merged into this project.

I just updated the tonesto7 SmartThings to homekit smart app to V2 and also plugin for homebridge to V2 and now the blinds appear back as switches... after doing the previous fix they appeared as blinds? ideas?

JJJ commented 4 years ago

after doing the previous fix they appeared as blinds? ideas?

That's not good. Perhaps a regression? I won't have time to look into this for a little bit, but when I do I'll try to reply here if no one beats me to it.