SDL window doesn't close properly in m64py

[GoogleCodeExporter]

Hi,

When video extension is disabled in m64py, after rom is stopped sdl window 
doesn't close.
When I use mupen64plus 2.0 release from Downloads section it works and sdl 
window is closed properly, but with code compiled from git (with SDL2) sdl 
window stays open.

I tried to find what has changed in core in the meantime that could cause this 
but without success, I am no C expert.

I am not sure, maybe problem is with m64py, but so far I didn't found what 
causes this. 

Original issue reported on code.google.com by gen2br...@gmail.com on 23 Jan 2014 at 12:04

[GoogleCodeExporter]

I get a weird message when doing start-stop-start-stop sequence with m64py 
(regardless of the vidext). It is weird because I've used rsp-hle and 
video-glide64mk2.... not rsp-z64 and video-rice.

Frontend: DEBUG: plugin_shutdown()
Frontend: WARNING: NOT_INIT: A function was called before it's associated 
module was initialized
Frontend: WARNING: Z64 RSP Plugin failed to stop.
Frontend: DEBUG: plugin_shutdown()
Frontend: WARNING: NOT_INIT: A function was called before it's associated 
module was initialized
Frontend: WARNING: Z64 RSP Plugin failed to stop.
Frontend: DEBUG: plugin_shutdown()
Frontend: WARNING: NOT_INIT: A function was called before it's associated 
module was initialized
Frontend: WARNING: Mupen64Plus OpenGL Video Plugin by Rice failed to stop.

Now to your problem: Can you please try following patch: 
http://anonscm.debian.org/gitweb/?p=collab-maint/mupen64plus-core.git;a=blob;f=d
ebian/patches/sdl2_destroywindow.patch;h=1ce5b2bd7d947ccab77b9265126b822d88459fa
a;hb=HEAD

Original comment by s...@narfation.org on 23 Jan 2014 at 2:04

[GoogleCodeExporter]

Yes, works perfectly now. Thanks! 

About these errors, I will take a look. I recently rewrote code that does 
load/startup/shutdown plugins.
Currently, it does startup all found plugins (I need this for plugins 
config/settings), and shutdowns/unloads them when program exit.
On rom start/stop it only attaches/detaches chosen plugins, it doesn't do 
stop/start on them.

I think that is why when video plugin is changed in m64py it needs restart, 
otherwise only black screen is shown.
I looked at mupen64plus-ui-console, but there frontend doesn't stay open to 
pick some other rom so I am not sure what is the proper way to do this.

Original comment by gen2br...@gmail.com on 23 Jan 2014 at 4:29

[GoogleCodeExporter]

I've only used m64py 0.1.9 - so maybe this behaviour is not happening anymore 
in the current HEAD. But I don't have the time right now to look more into the 
code to see who is responsible for these warnings

Original comment by s...@narfation.org on 23 Jan 2014 at 5:39

[GoogleCodeExporter]

Ok, I found a bug with glcontext, now plugins can be changed without restart. 
Please try current HEAD when you have a time. Code is now also on github 
https://github.com/gen2brain/m64py .

Thanks,
Milan

Original comment by gen2br...@gmail.com on 23 Jan 2014 at 11:01

[GoogleCodeExporter]

Ok, will check it later.

Btw. sourceforge is still your main repo and you just sync the data to github? 
Because the github stuff is missing the tags.

Original comment by s...@narfation.org on 24 Jan 2014 at 9:50

[GoogleCodeExporter]

Yes, sourceforge is still main repo, I just added new remote. I will see how 
can I migrate tags.

Original comment by gen2br...@gmail.com on 24 Jan 2014 at 1:03

[GoogleCodeExporter]

I will close the issue because the patch is now merged (in a slightly modified 
form).

Just tested the master branch and the plugin unload problem is fixed in it 
(good work). But the glinit branch re-introduces the nvidia-glx problem on 
Ubuntu/Debian.

Original comment by s...@narfation.org on 26 Jan 2014 at 10:25

• Changed state: Fixed