search

toniebox-reverse-engineering / teddycloud_web

A better web interface for TeddyCloud
https://github.com/toniebox-reverse-engineering/teddycloud/
17 stars 9 forks source link

Solve settings save issue #123

Closed naymecliff closed 2 months ago

naymecliff commented 2 months ago

I implemented a Singleton to track option changes and make an over all settings save. This applies to all 4 (3) types of OptionItem. The buttons will only be shown if there are any changes. The position is fixed at the bottom. Feel free to change it. The SettingsButtons will work everywhere you put them.

To have a cleaner code and because I am not completely sure what the overlays do, I made new components for the settings' input fields. My changes could be used or inspirational for the overlays later on.

henryk86 commented 2 months ago

src\components\tonieboxes\TonieboxSettingsPage.tsx

that should be overworked also.

henryk86 commented 2 months ago

I would display the buttons always and disable them if nothing is changed. Thats the current behaviour on all other pages.

naymecliff commented 2 months ago

Closing in favor of develop branch pull request