tontof / kriss_feed

A simple and smart (or stupid) feed reader
282 stars 54 forks source link

Having the possibility to 'undo' the last 'mark as read' action and/or not hide items which are just read (filter==='unread') #266

Closed matttbe closed 11 years ago

matttbe commented 11 years ago

Hello,

Here is a new feature request :) I think it can be interesting to have the possibility to undo the last 'mark as read' action because it's too easy to mark an item as read and it's not so easy to mark this item as unread: with the expanded view and when only unread item are listed, we have to list all items, find this item and mark it as unread.

Here is two ideas:

But note that it's not impossible to undo the last action so it's not a critical issue :)

matttbe commented 11 years ago

About the second point, I think it's easy to implement that: simply by having to possibility to not call removeElement(item); in script.js:620 :)

matttbe commented 11 years ago

I don't know if you want to add a new option (or maybe you prefer adding a dedicated plugin for that?) but here is a new proposition!

It didn't take a long time to do that, if you don't want it, it's absolutely not a problem, I can also just remove the line removeElement(item); in my index.php file ;)

tontof commented 11 years ago

Well actually I've already planned to do that without plugin nor option, but it will be only available with javascript. In version 4 it was what I was doing and I miss it now but I did not have time to code it again. The idea is only to keep the 10 last items hash in javascript and when we go back if we are on the first element it looks in the history. I think there is no problem when showing all items (!= unread). https://github.com/tontof/kriss_feed/issues/25 I think this should answer your problem ?

matttbe commented 11 years ago

I think this should answer your problem ?

Yes and no :) In fact, I don't use pages (I don't display these buttons to go to the next/previous page, etc.). KF displays 50 items per page and when I'm at the end of the page, I reload KF (thanks to 'r' shortkey :) ).

So yes if your feature is implemented, I can switch to the previous page if I want to re-read the previous item but I think this is a strange behaviour :) If it's not explained, I don't think I will try to switch to the previous page to have this behaviour! I prefer to not hide what I just read and to grey out these items. I think it's more "user-friendly": with this behaviour I know immediately than I can mark an item as unread if I want to undo my previous action :)

tontof commented 11 years ago

Well why don't you use show all item then and go to next and previous page with 'N' and 'P' ? For me this is the difference between these two modes. It does not remove the element after reading it. For now I will not integrate your modification in order not to complicate config as I want to move most of the stuff with plugins. But I guess it will be a good idea to do a plugin for what you did

matttbe commented 11 years ago

Because some read items are always displayed at the beginning :) (e.g. items from agendas) And I don't want to scroll down to find all my unread items. (e.g. if I have 30 new items and I only read the 10 first items)

I prefer that just to not be "stressed": without this feature I have to pay attention to what I'm doing, to not click on 'Read' button too faster (I use to read quickly some feeds which only have a title and a short description and I mechanically click on the 'Read' button but sometime, I realise a bit after that the subject was interesting... too late)

But I understand that you don't want it now/like that and I can also just remove one line ;) (I already remove other lines to download all old and new unread items ;) )

tontof commented 11 years ago

And with the newer first option ?

No worry, the best is that you can find what you're looking for :-) I will see when I will implement the javascript history, but I'm nearly sure it will fit your need ^^

tontof commented 11 years ago

I've added to #97 so I close but I keep in mind :-)

matttbe commented 11 years ago

And with the newer first option ?

Which one? :)

tontof commented 11 years ago

http://tontof.net/feed/?order=newerFirst

matttbe commented 11 years ago

Because it's not unread first :þ

Because some read items are always displayed at the beginning :) (e.g. items from agendas) And I don't want to scroll down to find all my unread items. (e.g. if I have 30 new items and I only read the 10 first items, the next time, I'll have to scroll down 10 items: it can be long when using the expanded view :) )

But I prefer to remove this line, it's what I want and it's not complicated to remove this line ^^

tontof commented 11 years ago

http://tontof.net/feed/?order=newerFirst&filter=unread ? Well actually I don't understand why removing this line correct your problem of items from agendas that appear anyway ? But as you said, if it's what you want, no worries :-)

matttbe commented 11 years ago

http://tontof.net/feed/?order=newerFirst&filter=unread Well actually I don't understand why removing this line correct your problem of items from agendas that appear anyway ?

I'm using this mode (with the expanded view) but if I mark an item as read, it disappears (due to removeElement(item); and it's more complicated to mark it as unread). I just prefer that it disappears after having refreshed the page, no worries ;)

tontof commented 11 years ago

Oups, it was http://tontof.net/feed/?order=newerFirst&filter=all not unread !

matttbe commented 11 years ago

^^ but it's not unread first:

I don't want to scroll down to find all my unread items. (e.g. if I have 30 new items and I only read the 10 first items, the next time, I'll have to scroll down 10 items: it can be long when using the expanded view :) ) Some read items are always displayed at the beginning :) (e.g. items from agendas with a pubDate in the future)

tontof commented 11 years ago

Well I guess it's because of your agenda feeds because I don't have future items and so for me with http://tontof.net/feed/?order=newerFirst&filter=all I have unread first :-)

matttbe commented 11 years ago

Not if you start marking as read the first ones and then reloading the page :-)

tontof commented 11 years ago

Indeed I did not think about that...

Nodd commented 11 years ago

I'm interested in the second point ! I don't think there's a way to remove the offending line using plugins ?

tontof commented 11 years ago

Well I did not take time to look at this for now :-( I really miss the history management in javascript as it really painfull to look at old items just marked as read which has disappeared... I think I've find a way to implement more properly the javascript part, I just have to find time to do that