search

tontof / kriss_feed

A simple and smart (or stupid) feed reader
280 stars 54 forks source link

Shaarli popup window doesn't have a scroll bar in Firefox. #398

Open poVoq opened 6 years ago

poVoq commented 6 years ago

Not sure if that can be fixed easily, but the "share" pop-up for Shaarli is very hard to use on smaller screens as you can't scroll in it. The only way to use it is by pressing tab to reach all the fields. Edit: or with the markdown toolbar enabled, switching between the fullscreen mode and back resets the popup window to the top.

Also: it there an option to hide/rename the "share" button for public non-logged in view? It might confuse people with other kinds of social sharing.

poVoq commented 6 years ago

This explains the relevant settings: https://developer.mozilla.org/en-US/docs/Web/API/Window/open

tontof commented 6 years ago

markdown toolbar? I'm not sure I understand what you mean by that. For now, I've modified the scrollbar so that it will possible to scroll on this pop-up https://github.com/tontof/kriss_feed/commit/43f0c543dc718278755f8f3324769d5d673a3d0f

For the share button, I guess the best thing is to add a custom css:

.item-shaarli {display: none;}
tontof commented 6 years ago

Available for now only on the dev index: https://raw.githubusercontent.com/tontof/kriss_feed/master/src/index.php

poVoq commented 6 years ago

markdown toolbar? I'm not sure I understand what you mean by that.

In Shaarli, a plugin to allow easier markdown editing.

.item-shaarli {display: none;}

But then it would not be visible/usable at all. I would like to have it available for logged in users, or maybe better rename it to "Shaarli" so that people don't get confused.

It seems to recognize if a link was shared previously, but always opens up the Shaarli editor (or asks for a login). Better would be if it could redirect to the existing Shaarli entry in read mode (permalink) for already shared links, as thus also public readers could easily see the additional notes (and user comments if that is enabled in Shaarli). If you actually want to edit a share, then that's easily possible from within Shaarli then.

tontof commented 6 years ago

I understand the idea for the Shaarli part, but it's too difficult and specific. The fact that it recognizes that a link was previously shared is because of Shaarli behavior and occurs only when you are logged in so that in public mode it can not be redirect on the user comments.

For the shaarli link, to hide it only in public

#index[data-is-logged=""] .item-shaarli {
    display: none;
}