tonybaloney / CSnakes

Embed Python in .NET
https://tonybaloney.github.io/CSnakes/
MIT License
343 stars 24 forks source link

Complete generator support for return value #288

Closed atifaziz closed 1 month ago

atifaziz commented 1 month ago

This PR completes the implementation of generator support by adding and testing the ability to retrieve the return value from a generator function.

Summary of changes:

tonybaloney commented 1 month ago

Please can you extend this test so that it verifies that the generator returned True, or change the generator to return something more exotic incase we accidentally return a truthy value anyway

https://github.com/tonybaloney/CSnakes/blob/main/src/Integration.Tests/GeneratorTests.cs#L14

atifaziz commented 1 month ago

Please can you extend this test so that it verifies that the generator returned True, …

I'm not sure what's missing since the test was already extended.

aaronpowell commented 1 month ago

Looks good to me pending @tonybaloney's desires on testing

tonybaloney commented 1 month ago

Sorry I didn't see the additional test change. LGTM