search

tonybaloney / Pyjion

Pyjion - A JIT for Python based upon CoreCLR
https://www.trypyjion.com
MIT License
1.42k stars 59 forks source link

Fetch the range of interned integers from the interpreter state #88

Open todo[bot] opened 3 years ago

todo[bot] commented 3 years ago

https://github.com/tonybaloney/Pyjion/blob/4b35f298a87f2f99f29c821c57a0cf95188c1593/src/pyjion/absint.h#L392-L394

This issue was generated by todo based on a TODO comment in 4b35f298a87f2f99f29c821c57a0cf95188c1593 when #87 was merged. cc @tonybaloney.
aeroaks commented 3 years ago

Hi, I would like to try out. I am working with Python for sometime but this would be first time this level. Hope I can contribute and learn more :) How can I tackle this? How can I setup the dev env?

tonybaloney commented 3 years ago

@aeroaks that would be great.

The implementation of this issue will be 100% C++, so if you're still ok with that?

To implement this you should:

tonybaloney commented 3 years ago

To setup the dev environment, you can use the .devcontainer in VS Code. Clone this project with the remote container plugin enabled and it should set everything up for you

aeroaks commented 3 years ago

Thanks. I am waiting for few parts for my personal PC, will pick up this issue after setting up the PC. Hopefully it is not urgent.

tetsuo-cpp commented 3 years ago

@aeroaks Are you still planning to do this? If not, I'm happy to take this one.

aeroaks commented 3 years ago

@tetsuo-cpp Please take this, I am not able to find time for this. Thanks

tetsuo-cpp commented 3 years ago

@tonybaloney I had a look at this last night but wasn't sure how to get the interned integer range from the PyInterpreterState. From the CPython version that I'm looking at, those #define macros and the actual array of interned integers are in a longobject.c and aren't exposed in any way via the API.

Seems like we might need to keep these as constants in Pyjion.