tonyofrancis / Fetch

The best file downloader library for Android
https://www.meta.stackoverflow.com/tags/fetch2
Apache License 2.0
1.64k stars 337 forks source link

SecurityException #574

Open AlirezaGhanbarinia opened 3 years ago

AlirezaGhanbarinia commented 3 years ago

thank you for useful library

A crash has been reported in our crash log reffering to Fetch library.would you please check this log? Device : Samsung Galaxy A50 (Android 11)

java.lang.RuntimeException: at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3792) at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3968) at android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:85) at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135) at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95) at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2307) at android.os.Handler.dispatchMessage (Handler.java:106) at android.os.Looper.loop (Looper.java:246) at android.app.ActivityThread.main (ActivityThread.java:8506) at java.lang.reflect.Method.invoke (Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:602) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1130) Caused by: java.lang.SecurityException: at android.os.Parcel.createExceptionOrNull (Parcel.java:2385) at android.os.Parcel.createException (Parcel.java:2369) at android.os.Parcel.readException (Parcel.java:2352) at android.os.Parcel.readException (Parcel.java:2294) at android.net.IConnectivityManager$Stub$Proxy.listenForNetwork (IConnectivityManager.java:4703) at android.net.ConnectivityManager.sendRequestForNetwork (ConnectivityManager.java:4191) at android.net.ConnectivityManager.registerNetworkCallback (ConnectivityManager.java:4594) at android.net.ConnectivityManager.registerNetworkCallback (ConnectivityManager.java:4564) at com.tonyodev.fetch2.provider.NetworkInfoProvider.<init> (NetworkInfoProvider.java:52) at com.tonyodev.fetch2.fetch.FetchModulesBuilder$Modules.<init> (FetchModulesBuilder.java:103) at com.tonyodev.fetch2.fetch.FetchModulesBuilder.buildModulesFromPrefs (FetchModulesBuilder.java:53) at com.tonyodev.fetch2.Fetch$Impl.getInstance (Fetch.java:1026) at com.gapafzar.messenger.view.DownloadManager.<init> (DownloadManager.java:51) at com.gapafzar.messenger.view.DownloadManager$Companion$instance$2.invoke (DownloadManager.java:30) at com.gapafzar.messenger.view.DownloadManager$Companion$instance$2.invoke (DownloadManager.java:28) at kotlin.SynchronizedLazyImpl.getValue (SynchronizedLazyImpl.java:74) at com.gapafzar.messenger.view.DownloadManager$Companion.getInstance (DownloadManager.java:2) at com.gapafzar.messenger.activity.MainActivity.onCreate (MainActivity.java:823) at android.app.Activity.performCreate (Activity.java:8198) at android.app.Activity.performCreate (Activity.java:8182) at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1309) at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3765) at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3968) at android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:85) at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135) at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95) at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2307) at android.os.Handler.dispatchMessage (Handler.java:106) at android.os.Looper.loop (Looper.java:246) at android.app.ActivityThread.main (ActivityThread.java:8506) at java.lang.reflect.Method.invoke (Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:602) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1130) Caused by: android.os.RemoteException: at android.app.AppOpsManager.checkPackage (AppOpsManager.java:7783) at com.android.server.ConnectivityService.ensureSufficientPermissionsForRequest (ConnectivityService.java:8535) at com.android.server.ConnectivityService.listenForNetwork (ConnectivityService.java:8804) at android.net.IConnectivityManager$Stub.onTransact (IConnectivityManager.java:2127) at android.os.Binder.execTransactInternal (Binder.java:1190)

alexanderprodan commented 3 years ago

Hey! We got the same issue that leads to an instant app crash. We believe the root cause is an exception thrown by the Android OS. Another library has fixed it like that: https://github.com/DataDog/dd-sdk-android/commit/58c1adf2d7ee485b551b3adff25b11eee0f4b4a9

Any chance to get a fix for that. :) Thanks a lot and keep up the good work!