search

toolbox-team / reddit-moderator-toolbox-legacy

LEGACY VERSION do not use
http://www.reddit.com/r/toolbox
Apache License 2.0
66 stars 40 forks source link

Queue kitteh doesn't like Firefox :( #471

Closed TheEnigmaBlade closed 9 years ago

TheEnigmaBlade commented 9 years ago

The tb-kitteh class is properly applied to the element, but the CSS isn't applied (doesn't show up in any dev tools). Still works fine in Chrome.

TheEnigmaBlade commented 9 years ago

It seems the fault lies with background-image. Attempting to add a rule via Firebug shows some CSS is applied (probably the kitteh CSS) but is just not working:

Setting this custom background-image to be !important overrides the problem CSS and kitteh works.

I just don't know why the extension CSS is having problems and how to fix it.

I said that too soon. Manually setting the protocol of the URL (ex. //b.thumbs.redditmedia.com to https://b.thumbs.redditmedia.com) fixes the issue. Not sure why, though, because Firefox should support protocol-relative URLs.

creesch commented 9 years ago

We don't need relative urls, just use https. Relative urls have presented issue with chrome as well with similar stuff. In fact I am 99% sure it was not a relative url before.

In fact f35ecc2a23747246f34940d181dd652e83e3e74c broke it.

amici-ursi commented 9 years ago

@TheEnigmaBlade Didn't you fix this? cbaf9db680e83ef5b2940a7671faf9d45f0fee42