search

toolbox-team / reddit-moderator-toolbox-legacy

LEGACY VERSION do not use
http://www.reddit.com/r/toolbox
Apache License 2.0
66 stars 40 forks source link

replace/update spectrum colorpicker with one that doesn't use deprecated jquery functionality. #841

Closed creesch closed 6 years ago

creesch commented 7 years ago

Spectrum uses jQuery.fn.bind(), jQuery.fn.unbind() and jQuery.fn.delegate() all three are deprecated in jquery.

creesch commented 7 years ago

Seems like we can use html5 colorpicker without much issue. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/color

I still need to double check with Edge if it works there as well.

eritbh commented 6 years ago

Looks like it's all good

eritbh commented 6 years ago

Only instances of this seem to be in core config and domain tagger.

eritbh commented 6 years ago

This will be interesting because apparently the default UN colors are stored as color names instead of hex codes. We'll have to find a way to parse those colors there. (dunno if this also applies to domain tagging, haven't tested thoroughly)

creesch commented 6 years ago

I already fixed this in the redesign. You can backport that code.

eritbh commented 6 years ago

Fixed in 311a465c174753e42b59d77ec3af1dc3c263edb1