search

topcoder-platform / mfe-customer-work

3 stars 10 forks source link

Frame sizing for Vanilla discussion #41

Closed jmgasper closed 2 years ago

jmgasper commented 2 years ago

@nursoltan-s - I'm seeing that the frame isn't fully showing. This means that the bottom of the Vanilla frame is slightly cut off - can we fix that please?

Screen_Shot_2022-01-19_at_7_57_08_am
nursoltan-s commented 2 years ago

@jmgasper Hi,Please check these 2 MRs:https://github.com/topcoder-platform/micro-frontends-self-service-app/pull/43 https://github.com/topcoder-platform/micro-frontends-navbar-app/pull/67

For navbar repo, I found a bug from yesterday's merged code. And I fixed it. Can you please check it?

ThomasKranitsas commented 2 years ago

@jmgasper update please?

jmgasper commented 2 years ago

@ThomasKranitsas - This is done. Closing now. Sorry, was tracking this in a separate repo.