topcoder-platform / micro-frontends-forums-app

MIT License
1 stars 1 forks source link

[$450] Create skeleton MFE #2

Closed jmgasper closed 3 years ago

jmgasper commented 3 years ago

This ticket will track creating a skeleton MFE that just embeds the Vanilla code and exposes it as an app in the MFE, with the MFE header and footer.

The embed code should be configurable, since we'll have different code / targets for prod and dev.

Here's the current embed code to use:

<script type="text/javascript" src="https://vanilla.topcoder-dev.com/js/embed.js"></script>
<noscript>
    Please enable JavaScript to view the
    <a href="http://vanillaforums.com/?ref_noscript">
        discussions powered by Vanilla.
    </a>
</noscript>
<div class="vanilla-credit">
    <a class="vanilla-anchor" href="http://vanillaforums.com">
        Discussions by <span class="vanilla-logo">Vanilla</span>
    </a>
</div>
jmgasper commented 3 years ago

Challenge https://www.topcoder.com/challenges/8780b0f0-bd63-4f1d-8300-cb863f0e5587 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

jmgasper commented 3 years ago

Challenge https://www.topcoder.com/challenges/8780b0f0-bd63-4f1d-8300-cb863f0e5587 has been assigned to yoution.

This is an automated message for ghostar via Topcoder X

yoution commented 3 years ago

@jmgasper I added this forums app to the micro-frontends-frame pleas review https://github.com/topcoder-platform/micro-frontends-frame/pull/34 this project, I have pushed to the master branch, please review https://github.com/topcoder-platform/micro-frontends-forums-app/tree/master

jmgasper commented 3 years ago

@yoution - Thanks, I'm working on the deploy. Please target the develop branch going forward, since that will deploy to the dev environment. Prod will work off master

yoution commented 3 years ago

@jmgasper I have pushed to the develop branch, please try to deploy

yoution commented 3 years ago

@jmgasper how can I show the forums? these code can show the forum? can you give me the old forums for reference?

<script type="text/javascript" src="https://vanilla.topcoder-dev.com/js/embed.js"></script>
<noscript>
    Please enable JavaScript to view the
    <a href="http://vanillaforums.com/?ref_noscript">
        discussions powered by Vanilla.
    </a>
</noscript>
<div class="vanilla-credit">
    <a class="vanilla-anchor" href="http://vanillaforums.com">
        Discussions by <span class="vanilla-logo">Vanilla</span>
    </a>
</div>
yoution commented 3 years ago

ok, I will check the embed.js file

jmgasper commented 3 years ago

Payment task has been updated: https://www.topcoder.com/challenges/8780b0f0-bd63-4f1d-8300-cb863f0e5587 Payments Complete Winner: yoution Copilot: ghostar Challenge 8780b0f0-bd63-4f1d-8300-cb863f0e5587 has been paid and closed.

This is an automated message for ghostar via Topcoder X