[$400] Investigate Vanilla navigation

jmgasper commented 3 years ago

Vanilla is running in an MFE (locally). The current issue I'm seeing is that the links to navigate to categories, start a new discussion, etc... aren't redirected properly, so the MFE just always defaults back to the main screen. I'm not sure what we can do here, but maybe we add in a handler to the MFE to somehow redirect and then display the right Vanilla page?

)

yoution commented 3 years ago

@jmgasper this state is self-assigned, you are working on this one?

atelomycterus commented 3 years ago

@jmgasper this state is self-assigned, you are working on this one?

@yoution I am working on this ticket.Thanks!

jmgasper commented 3 years ago

Challenge https://www.topcoder.com/challenges/a846abfc-004e-4d36-882a-f3cf521f71f4 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

jmgasper commented 3 years ago

Challenge https://www.topcoder.com/challenges/a846abfc-004e-4d36-882a-f3cf521f71f4 ghostar has been unassigned.

This is an automated message for ghostar via Topcoder X

jmgasper commented 3 years ago

Challenge https://www.topcoder.com/challenges/a846abfc-004e-4d36-882a-f3cf521f71f4 has been assigned to ghostar.

This is an automated message for ghostar via Topcoder X

jmgasper commented 3 years ago

Challenge https://www.topcoder.com/challenges/a846abfc-004e-4d36-882a-f3cf521f71f4 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

atelomycterus commented 3 years ago

@jmgasper There are two techniques (simple and advanced) on how to configure embedding Vanilla. The simple one is used in micro-frontends-forums-app. For the sake of simplicity, I created an html file that contains a frame and deployed the Vanilla localhost. So I can be sure that errors are not related to Vanilla. Then I deployed it to http://embed.vanilla.localhost. There are an issue with log in for any providers.

localhost + The default Vanilla Authentication (login/password)/Topcoder Authentication Providers

http://localhost/ - not embedded, works without issues. http://localhost/embedded.php, both providers works. The main functionality works without errors but there are two issues with deleting a comment/discussion. The videos are attached

https://user-images.githubusercontent.com/10196632/143307939-955fb277-dc0b-408b-8de5-25ce1bd5468c.mp4 https://user-images.githubusercontent.com/10196632/143307949-507dec44-4ba9-4cc8-a1d0-98d34888fa1b.mp4

embed.vanilla.localhost + The default Vanilla Authentication (login/password)/Topcoder Authentication Providers

http://embed.vanilla.localhost/ - not embedded, works without issues. http://embed.vanilla.localhost/embedded.php, The Vanilla Forums is embbed in a frame + trusted hosts are configured. We can see all public forums only, but both 403 errors are shown for both providers in server logs. So user couldn’t log in with any providers. I am debugging it now.

Additional notes:

I’ve looked at Vanilla Forums source codes and I found out there is different logic in the several controllers which depends if the application runs as embedded or not. We need to review code and test micro-frontends-forums-app.
A lot of requests(paging/sorting/edit discussion/comments) change URL, so we need to detect URL changes in a SPA.

Keep you updated on it tomorrow.

jmgasper commented 3 years ago

Payment task has been updated: https://www.topcoder.com/challenges/a846abfc-004e-4d36-882a-f3cf521f71f4 Payments Complete Winner: obog Copilot: ghostar Challenge a846abfc-004e-4d36-882a-f3cf521f71f4 has been paid and closed.

This is an automated message for ghostar via Topcoder X

topcoder-platform / micro-frontends-forums-app

[$400] Investigate Vanilla navigation #3

localhost + The default Vanilla Authentication (login/password)/Topcoder Authentication Providers

embed.vanilla.localhost + The default Vanilla Authentication (login/password)/Topcoder Authentication Providers