tophat / monodeploy

:monorail: Like semantic-release and Lerna, but for Yarn modern workspaces
https://tophat.github.io/monodeploy/
Apache License 2.0
106 stars 7 forks source link

Race condition exists for autocommits if future changes are merged before the autocommit #601

Open dbasilio opened 1 year ago

dbasilio commented 1 year ago

Describe the bug

If your CI is building and autocommiting Commit 1, and Commit 2 is introduced between the initial merge and the autocommit, then monodeploy will fail to pull with rebase on Commit 2

To reproduce

If the following happens:

Expected behavior

This is hard to say, but I think we should follow a few guiding principles:

Environment (please complete the following information):

Additional context

noahnu commented 1 year ago

We could try build in some basic merge conflict resolver 🤔

Papooch commented 1 year ago

I think a simple retry would solve the majority of issues. If monodeploy detects this scenario, it should discard changes and rebase on top of the newest commit and try again, instead of trying to come up with some elaborate conflict resolution logic. What do you think?

noahnu commented 5 months ago

Monodeploy has been forked under a new name Monoweave. I've copied your issue over and will address it in the monoweave project.

https://github.com/monoweave/monoweave/issues/95