toradex / meta-toradex-security

MIT License
4 stars 9 forks source link

Move toradex-nxp-layer and toradex-ti-layer to LAYERRECOMMENDS #51

Closed tjallingt closed 3 months ago

tjallingt commented 3 months ago

I'm not sure if this works as I'm imagining it should but this PR "downgrades" toradex-nxp-layer and toradex-ti-layer from being "hard" dependency (meta-toradex-security won't build without both of these present) to a recommendation (this layer will build without but recommends both, this way you can also build using only one of these).

Issue: https://github.com/toradex/meta-toradex-security/issues/50

sergioprado commented 3 months ago

Makes sense to me. Out of curiosity, what is your use case? I would presume you are not using Toradex manifest files for the build, right?

I have a few suggestions on the pull request:

  1. Change the title of the commit to conf/layer.conf: move toradex-nxp-layer and toradex-ti-layer to LAYERRECOMMENDS
  2. Add a message in the commit describing why you are doing this change.
  3. Adapt the README file. I would remove the layers from the Layer dependencies session, and add them to a new session called Layers recommendations.
tjallingt commented 3 months ago

Yea we have a yocto setup that uses the meta-toradex-bsp-common and meta-toradex-ti layers (but not any of the other layers that are installed by https://git.toradex.com/cgit/toradex-manifest.git/).

As for meta-toradex-security we are evaluating using secure boot for the verdin-am62 . At the moment that means we also need to add meta-freescale-3rdparty, meta-freescale and meta-toradex-nxp layers to our yocto setup even though we are only building for the am62.

sergioprado commented 3 months ago

I have just one smal comment about the inclusion of the vscode file. Also, would you please sign-off the commit by adding a tag with your name and email? Example:

Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
tjallingt commented 3 months ago

thanks, i removed the file and added the sign-off message