toranb / ember-data-django-rest-adapter

An ember-data adapter for django web applications powered by the django-rest-framework
MIT License
152 stars 26 forks source link

Add `install through bower` #73

Closed dhilipsiva closed 10 years ago

dhilipsiva commented 10 years ago

bower install --save ember-data-django-rest-adapter

toranb commented 10 years ago

Would this project need a .bowerrc before you could install it like this?

davemerwin commented 10 years ago

only if you were using bower to manage the packages in ember-data-django-rest-adapter. Otherwise the .bowerrc would be setup by the client to manage the repos that they were using. At least that's how I do it. Here's an example: https://github.com/imsky/holder

toranb commented 10 years ago

Ok, so if we want to support bower we simply add the bower.json file. But don't we also need to start tagging each release? I assume bower prefers a tag of some kind? Do you have a solid post I could read for "authors" of bower packages? (thanks -sorry for all the questions)

dhilipsiva commented 10 years ago

Here it is: http://bower.io/#defining-a-package

dhilipsiva commented 10 years ago

Added bower.json file.

holandes22 commented 10 years ago

The bower.json file should specify the dependencies too, I think. This is great for the developer as you can clearly see upon which version of ember an ember-data each branch of the adapter depend on

toranb commented 10 years ago

Nice work ! The only thing left to do before pulling this in is to decide on the version number. In the past ember-data was under the 0.11 / 0.12 / 0.13 but a few months ago it went 1.0 beta

Currently we are on master as of 12/19 and I think it's technically 1.0 beta 4

Should we keep our version in sync w/ ember-data (using 1.0 beta 4 for example) or should we just start using our own version number? If we add a bowerrc file that shows the version of ember/ember-data then I don't know if we need to keep our version number in sync (unless the community wants to keep it that way).

Does anyone have an opinion one way or the other?

cc: @craigteegarden @apmorton @dustinfarris

craigteegarden commented 10 years ago

I think the version can be independent ad long as it is easy to know what version of ember data is used.

Great job! On Jan 4, 2014 9:39 AM, "Toran Billups" notifications@github.com wrote:

Nice work ! The only thing left to do before pulling this in is to decide on the version number. In the past ember-data was under the 0.11 / 0.12 / 0.13 but a few months ago it went 1.0 beta

Currently we are on master as of 12/19 and I think it's technically 1.0 beta 4

Should we keep our version in sync w/ ember-data (using 1.0 beta 4 for example) or should we just start using our own version number? If we add a bowerrc file that shows the version of ember/ember-data then I don't know if we need to keep our version number in sync (unless the community wants to keep it that way).

Does anyone have an opinion one way or the other?

cc: @craigteegarden https://github.com/craigteegarden @apmortonhttps://github.com/apmorton @dustinfarris https://github.com/dustinfarris

— Reply to this email directly or view it on GitHubhttps://github.com/toranb/ember-data-django-rest-adapter/pull/73#issuecomment-31579609 .

dustinfarris commented 10 years ago

I second @craigteegarden to keep the adapter's version independent since it evolves at a separate pace.

williamsbdev commented 10 years ago

If I may chime in, I would agree with the above two comments @craigteegarden @dustinfarris and say that this needs to be versioned independently.

toranb commented 10 years ago

I think we are doing to start by tagging the current version @ 1.0.0

@dhilipsiva can you please update the bower.json to set this as the current version? Also do we need to set the main (ie- it's pointing at src/main.js now I think but is this required? If it is, how does this work as the real source is under serializer / adapter)

Once we work through this, I'll add the dependencies so others using it get the correct version of ember-data / ember.js

toranb commented 10 years ago

I decided to pull this in and updated it quick (several people asking for this in the last 30 days)