search

toranb / ember-data-django-rest-adapter

An ember-data adapter for django web applications powered by the django-rest-framework
MIT License
152 stars 26 forks source link

Register library with Ember.libraries #75

Closed craigteegarden closed 10 years ago

craigteegarden commented 10 years ago

It looks like we used to register this library with Ember,libraries, but that is no longer in the source (https://github.com/toranb/ember-data-django-rest-adapter/commit/773c54b04b58b2a7f2a40106789e14cf7a36383e).

I think it would be useful to register the library and see the version in the debug output.

Did this get removed on purpose?

toranb commented 10 years ago

If we did it must have been an accident during the 0.13 => 1.0 rewrite. Is this something we can add to the grunt dist build? Or is this something bigger? I'm also curious how we can "build" a debug/prod build of this for the people using bower to install it

craigteegarden commented 10 years ago

It looks like ember uses a "shim" repository to handle the bower packaging: https://github.com/components/ember

Do we want to do something similar? What is required for bower packages?

toranb commented 10 years ago

I thought about it but decided that people would be less confused having just this repo on bower. Then using Grunt you just need to combine what's in the src directory (then assuming we do good work and tag each major release going fwd .... it should be as simple as setting a version and pulling it down with a quick "bower install")

Let me know if you feel we should do something more

craigteegarden commented 10 years ago

fixed by #76