search

toranb / ember-data-django-rest-adapter

An ember-data adapter for django web applications powered by the django-rest-framework
MIT License
152 stars 26 forks source link

Disable Ember minor version lock #79

Closed dustinfarris closed 10 years ago

dustinfarris commented 10 years ago

As stated in #78, it seems that it would be preferable to loosen the version requirement for Ember so the adapter can be used in a wider array of projects.

Going forward, we should only increase the minimum required version of Ember on an as-needed basis.

dustinfarris commented 10 years ago

@toranb I'm in the Philippines with a fickle internet connection and for the life of me can't get npm install to complete. Can I bother you to test this PR before I merge it?

dustinfarris commented 10 years ago

Oh, nevermind, Travis is taking care of that for me.

dustinfarris commented 10 years ago

@toranb it looks like the version requirement for karma in package.json is conflicting with other dependencies. Is there a reason we have karma locked to 0.10.0?

toranb commented 10 years ago

Ah yes - give me a few to look at this before merging (TLDR - karma 0.12 is half broken and I'm waiting a few weeks to update it)

toranb commented 10 years ago

I pushed up a fix for the grunt issue, but now the "replace" task is blowing up and I'm not sure why

@craigteegarden any chance you could pull master and run a simple "grunt test" for me to reproduce this error w/ the replace task? (assuming you know how the replace task works)

toranb commented 10 years ago

@craigteegarden here is the travis failure for more info

https://travis-ci.org/toranb/ember-data-django-rest-adapter/builds/21563249

craigteegarden commented 10 years ago

Alright I tracked down the problem. The issue is that the latest version of load-grunt-config is 0.8.0-beta.1 which has a bug (https://github.com/firstandthird/load-grunt-config/issues/46) that causes it to not expose the package.json config to other grunt tasks, which it normally does. This causes that replace task to error because it expects package.json to be available. This is fixed in 0.8.0-beta.2 (https://github.com/firstandthird/load-grunt-config/commit/85b83ddcf3fcb338b89e8f61793b0548a8f87da2) but that doesn't appear to be on npm yet.

I fixed this for now by locking load-grunt-config to ~0.7 so it avoids grabbing the 0.8.0-beta.1 version that has the issue.

Passing travis run: https://travis-ci.org/toranb/ember-data-django-rest-adapter/builds/21601825

toranb commented 10 years ago

Awesome! Thanks for the detailed break down @craigteegarden !!!

toranb commented 10 years ago

@dustinfarris can you pull in the 2 changes from master that @craigteegarden and I've made? Then merge and push this?

thanks again !!!