Closed kitsunde closed 10 years ago
Wow! excellent work on this! what version of DRF did this PATCH support change like you mentioned? I must be behind a few releases (or did I simply miss this altogether)
@toranb It has had support for it since 2.1.15 in January last year according to the release notes: http://www.django-rest-framework.org/topics/release-notes
Merge when you are ready my friend -I've added you as a full time contributor :)
@Celc what is the status on this?
I need to rebase on latest when I have some time over. It doesn't merge cleanly right now. Otherwise It should be good to go.
11 jul 2014 kl. 03:18 skrev Dustin Farris notifications@github.com:
@Celc what is the status on this?
— Reply to this email directly or view it on GitHub.
@Celc master is 2-space indentation now. Can you rebase?
I'll fix this when I have enough time to spare, work a bit hectic atm. :)
22 jul 2014 kl. 23:52 skrev Dustin Farris notifications@github.com:
@Celc I just switched everything to 2-space indentation. Can you rebase?
— Reply to this email directly or view it on GitHub.
@Celc totally understand. Let me know if you think you won't be able to get to it.
Closing in favor of #97.
It's because djangorestframework changes the expected method if we send back a partial update from
PUT
toPATCH
. Which means a simple attribute serialization override.Fails.
Instead adding support for readOnly attributes proposed but not (yet) implemented in https://github.com/emberjs/data/pull/303
Would serialize the model without the
profile_picture
attribute and send it as aPATCH
.I could also submit a pull request to have django-rest-adapter only send across data that has changed, rather than the whole model, in a similar fashion.