search

torchbox / wagtail-markdown

Markdown support for Wagtail
zlib License
198 stars 66 forks source link

Fixed wagtail dep #55

Closed thorin-schiffer closed 5 years ago

thorin-schiffer commented 5 years ago

https://github.com/torchbox/wagtail-markdown/issues/53

Tested on my project https://github.com/eviltnan/portfolio, everything seems to work fine.

I'd propose not to hard pin wagtail version, it's unprobable to break because of changes introduced in upcoming wagtail releases. Hard pin is preventing updating wagtail in a non-contradictory way.

kevinhowbrook commented 5 years ago

This assumes that the package will work on anything in the future, that doesn't seem right to me. If anything we would want something like Wagtail>=1.10,<2.5.

On a more wider note, I think we should remove this dependency completely. Wagtail Markdown shouldn't be dictating what version of wagtail to install, seen as though it's only going to be installed once you have wagtail installed, but looks like we need wagtail as a dependency for CI :man_shrugging:

thorin-schiffer commented 5 years ago

@kevinhowbrook could you please release that fix on pipy?

mfitzp commented 5 years ago

This also works fine with 2.5 as far as I can tell.

zoombear commented 5 years ago

Is this ready to go?

kevinhowbrook commented 5 years ago

Fixed in https://github.com/torchbox/wagtail-markdown/pull/60 Thanks all