Fix ambiguous column name when grouping with joins - Githubissues

tortoise / tortoise-orm

Familiar asyncio ORM for python, built with relations in mind

https://tortoise.github.io

Apache License 2.0

4.7k stars 391 forks source link

Fix ambiguous column name when grouping with joins #1766

Closed henadzit closed 2 weeks ago

henadzit commented 2 weeks ago

Description

Adds aliases to GROUP BY statements which helps to avoid ambiguous name errors.

Motivation and Context

This should fix https://github.com/tortoise/tortoise-orm/issues/1386 and fix https://github.com/tortoise/tortoise-orm/issues/1175.

How Has This Been Tested?

Added tests

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added the changelog accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 11766871659

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.162%

Totals
Change from base Build 11764062074:	0.0%
Covered Lines:	6084
Relevant Lines:	6709

💛 - Coveralls