Closed waketzheng closed 1 week ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
tortoise/backends/mysql/executor.py | 4 | 5 | 80.0% | ||
tortoise/contrib/postgres/functions.py | 9 | 10 | 90.0% | ||
tortoise/contrib/postgres/json_functions.py | 2 | 3 | 66.67% | ||
tortoise/queryset.py | 15 | 16 | 93.75% | ||
tortoise/validators.py | 28 | 29 | 96.55% | ||
tortoise/contrib/postgres/regex.py | 2 | 4 | 50.0% | ||
tortoise/contrib/mysql/json_functions.py | 11 | 16 | 68.75% | ||
tortoise/filters.py | 13 | 19 | 68.42% | ||
<!-- | Total: | 195 | 213 | 91.55% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
tortoise/contrib/mysql/search.py | 1 | 68.97% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 11908515480: | 0.2% |
Covered Lines: | 6231 |
Relevant Lines: | 6853 |
@waketzheng no need to change about this PR but it would be great to have two separate PRs in the future when you want to refactor the code. In this example it would be:
Having everything as a single PR makes it really hard to review actual logic changes. Thanks!
@waketzheng no need to change about this PR but it would be great to have two separate PRs in the future when you want to refactor the code. In this example it would be:
- PR for fixing enums not quoted
- Adding type hints
Having everything as a single PR makes it really hard to review actual logic changes. Thanks!
OK~
@abondar Cloud you merge it
Description
Fixes #1774 Depends on https://github.com/tortoise/pypika-tortoise/pull/10
Motivation and Context
Create this PR to verify the latest commit of pypika-tortoise
How Has This Been Tested?
make ci
Checklist: