coveralls
commented
1 week ago Pull Request Test Coverage Report for Build 11958477626
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 146 of 152 (96.05%) changed or added relevant lines in 11 files are covered.
- 3 unchanged lines in 1 file lost coverage.
- Overall coverage increased (+0.03%) to 89.53%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| tortoise/queryset.py | 103 | 109 | 94.5% | ||
| <!-- | Total: | 146 | 152 | 96.05% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| tortoise/backends/mysql/executor.py | 3 | 88.89% | ||
| <!-- | Total: | 3 | --> |
| Totals | |
|---|---|
| Change from base Build 11922917874: | 0.03% |
| Covered Lines: | 6246 |
| Relevant Lines: | 6867 |
henadzit
Description
This PR:
.count(),exists(),.values(),.values_list()). It does NOT implement parametrization of UPDATE and DELETE queries. I'll work on UPDATE and DELETE parametrization as part of a separate PR since this one is already quite big.AwaitableQuery._executeuses the same SQL as returned byAwaitableQuery.sql()by changing the signatures of_executeand_make_query.This PR is dependent on changes in pypika-tortoise https://github.com/tortoise/pypika-tortoise/pull/16. ⚠️ we should merge them first and release a new version of
pypika-tortoise!Motivation and Context
Parameterized queries are crucial for preventing SQL injection attacks and but also can improve performance of database operations.
How Has This Been Tested?
Checklist: